pylint-dev / pylint-pytest

A Pylint plugin to suppress pytest-related false positives.
https://pypi.org/project/pylint-pytest/
MIT License
14 stars 3 forks source link

Add pylint in the continuous integration and pre-commit #7

Closed Pierre-Sassoulas closed 10 months ago

Pierre-Sassoulas commented 10 months ago

Follow-up to #6

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (1c2613b) 86.96% compared to head (2fbc3db) 86.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7 +/- ## ======================================= Coverage 86.96% 86.96% ======================================= Files 33 33 Lines 399 399 Branches 81 81 ======================================= Hits 347 347 Misses 48 48 Partials 4 4 ``` | [Files](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/7?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) | Coverage Δ | | |---|---|---| | [tests/base\_tester.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/7?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvYmFzZV90ZXN0ZXIucHk=) | `88.70% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stdedos commented 10 months ago

idk why codecov is crying for, ignore it

Pierre-Sassoulas commented 10 months ago

For good names everything is either the pylint default or something not required now that pylint does not raise for <3 letters variables anymore

-good-names=ex,Run,_,i,j,k, # Defaults
-           rc,             # Return variable of `subprocess.xxx` methods
-           df,             # Panda's DataFrame variable
-           cd,             # Method/Context function that does `cd`. `cwd` is not much better
Pierre-Sassoulas commented 10 months ago

Great !