search

pylint-dev / pylint-pytest

A Pylint plugin to suppress pytest-related false positives.
https://pypi.org/project/pylint-pytest/
MIT License
14 stars 3 forks source link

Activate mypy in pre-commit #9

Closed Pierre-Sassoulas closed 10 months ago

Pierre-Sassoulas commented 10 months ago

Drafting because this will also be easier if we can do from __future__ import annotations after python 3.6 / 3.7 is dropped.

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (a444a61) 86.96% compared to head (b8ce4ad) 87.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #9 +/- ## ========================================== + Coverage 86.96% 87.82% +0.86% ========================================== Files 33 34 +1 Lines 399 419 +20 Branches 81 85 +4 ========================================== + Hits 347 368 +21 Misses 48 48 + Partials 4 3 -1 ``` | [Files](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/9?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) | Coverage Δ | | |---|---|---| | [tests/base\_tester.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/9?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvYmFzZV90ZXN0ZXIucHk=) | `91.04% <100.00%> (+2.33%)` | :arrow_up: | | [tests/base\_tester\_test.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/9?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvYmFzZV90ZXN0ZXJfdGVzdC5weQ==) | `100.00% <100.00%> (ø)` | | | [tests/test\_pytest\_yield\_fixture.py](https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/9?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-dGVzdHMvdGVzdF9weXRlc3RfeWllbGRfZml4dHVyZS5weQ==) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stdedos commented 10 months ago

Drafting because this will also be easier if we can do from __future__ import annotations after python 3.6 / 3.7 is dropped.

Oooh damn 😓 Now I see what you meant.

Nothing warned me that from __future__ import annotations is not a valid py3.6 flag 😕

stdedos commented 10 months ago

Heeey - apparently not blocked (and not a total disaster)

Pierre-Sassoulas commented 10 months ago

Actually we'll just have to revert https://github.com/pylint-dev/pylint-pytest/pull/9/commits/b8ce4adaade3031a11368a7ec2e5da067531b5f3