pylint-dev / pylint

It's not just a linter that annoys you!
https://pylint.readthedocs.io/en/latest/
GNU General Public License v2.0
5.26k stars 1.12k forks source link

False positive ``unreachable-code`` when using ``typing.Any`` as return in python 3.8 #9753

Closed Pierre-Sassoulas closed 3 months ago

Pierre-Sassoulas commented 3 months ago

Type of Changes

Type
βœ“ :bug: Bug fix

Description

Closes #9751 regression introduced in #9714 by https://github.com/pylint-dev/pylint/commit/c41c35a8e0dd71ba96944613e6a2ced830407670

github-actions[bot] commented 3 months ago

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 6017597420602fa8a783b4828232d43135cef368

jacobtylerwalls commented 3 months ago

Looks good, happy to approve once the functional tests are altered for 3.8

Pierre-Sassoulas commented 3 months ago

Thank you for the review. I wanted to validate the approach before committing to refactoring the functional tests. (wondered if you wanted to fix python 3.8). Should be mergeable now, What do you think about releasing 3.2.5 directly with only this ? It's a regression and there's a lot of traffic on #9751

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.84%. Comparing base (9f423bb) to head (549eb4d). Report is 10 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pylint-dev/pylint/pull/9753/graphs/tree.svg?width=650&height=150&src=pr&token=ZETEzayrfk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev)](https://app.codecov.io/gh/pylint-dev/pylint/pull/9753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) ```diff @@ Coverage Diff @@ ## main #9753 +/- ## ======================================= Coverage 95.84% 95.84% ======================================= Files 174 174 Lines 18878 18878 ======================================= Hits 18094 18094 Misses 784 784 ``` | [Files](https://app.codecov.io/gh/pylint-dev/pylint/pull/9753?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) | Coverage Ξ” | | |---|---|---| | [pylint/checkers/utils.py](https://app.codecov.io/gh/pylint-dev/pylint/pull/9753?src=pr&el=tree&filepath=pylint%2Fcheckers%2Futils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-cHlsaW50L2NoZWNrZXJzL3V0aWxzLnB5) | `96.16% <ΓΈ> (ΓΈ)` | |
github-actions[bot] commented 3 months ago

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 549eb4d94f4c6d8e28dade49b0feb4d98105c358