pylint-dev / pylint

It's not just a linter that annoys you!
https://pylint.readthedocs.io/en/latest/
GNU General Public License v2.0
5.32k stars 1.14k forks source link

Fix to maintain order of package paths #9887

Closed akamat10 closed 2 months ago

akamat10 commented 2 months ago

Type of Changes

Type
:bug: Bug fix

Description

Refs #9883

Addresses the indeterminacy identified in #9883

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.80%. Comparing base (6bb335f) to head (8901361). Report is 5 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/pylint-dev/pylint/pull/9887/graphs/tree.svg?width=650&height=150&src=pr&token=ZETEzayrfk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev)](https://app.codecov.io/gh/pylint-dev/pylint/pull/9887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) ```diff @@ Coverage Diff @@ ## main #9887 +/- ## ======================================= Coverage 95.80% 95.80% ======================================= Files 174 174 Lines 18944 18944 ======================================= Hits 18149 18149 Misses 795 795 ``` | [Files](https://app.codecov.io/gh/pylint-dev/pylint/pull/9887?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev) | Coverage Δ | | |---|---|---| | [pylint/lint/pylinter.py](https://app.codecov.io/gh/pylint-dev/pylint/pull/9887?src=pr&el=tree&filepath=pylint%2Flint%2Fpylinter.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pylint-dev#diff-cHlsaW50L2xpbnQvcHlsaW50ZXIucHk=) | `96.65% <ø> (ø)` | |
github-actions[bot] commented 2 months ago

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 15be85988354dea0e51c0855d5ed08bf63a399ea

akamat10 commented 2 months ago

Thank you for opening the PR and thank you for the analysis. Can you add a fragment describing the fix in https://github.com/pylint-dev/pylint/tree/main/doc/whatsnew/fragments, please ? Will do. Also I suppose you used dict.fromkeys for performance reasons compared to sorted or something else ? The intent was to avoid duplication of paths as the previous code did and also have a deterministic order. After this change, whether or not we see the error I mentioned in the issue will depend on the order of file and modules specified in the command line.

github-actions[bot] commented 2 months ago

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit d0ae7def2e3fdec2a4050b4bdea835b53f748272

github-actions[bot] commented 2 months ago

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 8901361f4776c30abfbe7313e9f9c6006090b161