pylipp / financeager

Organize your finances easily - from the command line!
GNU General Public License v3.0
82 stars 22 forks source link

Change signature of Client.__init__() #57

Closed pylipp closed 4 years ago

pylipp commented 4 years ago

In the clients.create() function, sinks and configuration are passed to construct a Client instance: https://github.com/pylipp/financeager/blob/f4f9675703ac93b4a7f00503582e044b6d0602f5/financeager/clients.py#L31

This due to both FlaskClient and LocalServerClient requiring these arguments. If another custom Client subclass is implemented, it is possible that the instantiation above fails because Client.__init__() only requires the sinks argument.

Solution