Closed azataiot closed 2 years ago
这是来自QQ邮箱的假期自动回复邮件。您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。
感谢回复,祝你假期愉快!我创建了一个新的fork,准备去实现一下这个功能。
如果需要改功能可以参考我提交的PR [#168 ](#168)
Hello.
Sorry, but why we trying manual management this process, if django has special api default_storage
for this.
If we will use it for file uploading we can:
upload_to_S3
and s3_check_existence
, because uploader will inherit common behavior from settings.py
.django-storage
because use default_storage
we automatically inherit correct processing for settings like DEFAULT_FILE_STORAGE
https://django-storages.readthedocs.io/en/latest/backends/amazon-S3.htmlIm prepare PR #173 For you could check it out.
Or correct me if I'm wrong in my hypothesis.
Hello.
Sorry, but why we trying manual management this process, if django has special api
default_storage
for this.If we will use it for file uploading we can:
- Remove config parameters like
upload_to_S3
ands3_check_existence
, because uploader will inherit common behavior fromsettings.py
.- Brake dependencies from concrete implementation storage.
- Improve integration with
django-storage
because usedefault_storage
we automatically inherit correct processing for settings likeDEFAULT_FILE_STORAGE
https://django-storages.readthedocs.io/en/latest/backends/amazon-S3.htmlIm prepare PR #173 For you could check it out.
Or correct me if I'm wrong in my hypothesis.
I believe this is more general and beautiful solution, yet I am still checking whether it works with some special cases.
我现在的项目使用 django-storage 将static 文件都放到了s3 上面, 但是发现django-mdeditor 并不会将图片上传到s3