search

pyllyukko / user.js

user.js -- Firefox configuration hardening
MIT License
2.76k stars 232 forks source link

Favicon from GitLab doesn't display #464

Closed antmak closed 5 years ago

antmak commented 5 years ago

When I have a favicon like this

<link rel="shortcut icon" 
type="image/png" 
href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAKUlEQVRYhe3OIQEAAAACIP+f1hkWWEB6FgEBAQEBAQEBAQEBAQEBgXdgl/rw4n36B+EAAAAASUVORK5CYII=" 
id="favicon" 
data-original-href="/assets/favicon-7901bd695fb93edb07975966062049829afb56cf11511236e61bcf425070e36e.png">

i dont see it when using 'relaxed' user.js.

Regular favicons like

<link rel="shortcut icon" 
type="image/png" 
href="/assets/favicon-7901bd695fb93edb07975966062049829afb56cf11511236e61bcf425070e36e.png" 
id="favicon" 
data-original-href="/assets/favicon-7901bd695fb93edb07975966062049829afb56cf11511236e61bcf425070e36e.png">

seem OK

What can I do to see one properly?

Atavic commented 5 years ago

Try security.csp.experimentalEnabled set to false.

Related: https://github.com/ghacksuserjs/ghacks-user.js/issues/223

antmak commented 5 years ago

Try security.csp.experimentalEnabled set to false.

Unfortunately this doesn't work to me. The specified above favicon still looks like a white square.

pyllyukko commented 5 years ago

It's because your icon actually is a white square. I decoded it into a file and even with a regular image viewer it was a white square.

Try:

<link rel="shortcut icon" 
type="image/png" 
href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAMAAAAoLQ9TAAAAM1BMVEUAAAAAAAAAAKoAqgAAqqqqAACqAKqqVSKqqqp9fX0AAP8A/wAA////fX3/AP///wD///8rA+CKAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAACxIAAAsSAdLdfvwAAAAHdElNRQfUAxwRHSYokUbIAAAALklEQVR4nGNgAAFOMGBAAGoLgJkcYAQR5YQBDrwCyFrAACKAZgsHaQIYZiAJAACGigS6y5CZQgAAAABJRU5ErkJggg==" 
id="favicon">
antmak commented 5 years ago

:man_facepalming: Thanks for your attention. We've updated the gitlab, it works now