Remove GNU make dependency from postinstall

pylonide / pylon

Pylon IDE, a Cloud9 v2 descendant with some added extras and support for modern node >= 14.21.1 (v15.x, v16.x, v17.x, v18.x, v19.x, v20.x). OSS licensed.

GNU General Public License v3.0

217 stars 73 forks source link

Remove GNU make dependency from postinstall #38

Open exsilium opened 6 years ago

exsilium commented 6 years ago

As of moving to node-pty, the Windows native build of Cloud9v2 has become a low hanging fruit. Altought the npm i dependency installations are carried out successfully, the last step during postinstall fails due to reliance on GNU make. The Makefile targets are actually using simple unix shell commands.

Proposal is to migrate the required installation Makefile steps to build/postinstall.js and use shelljs commands as platform agnostic substitute.

sr229 commented 5 years ago

We can try Grunt steps in place instead.

exsilium commented 5 years ago

Definitely grunt or gulp would be an option as a full featured task runners. I'm still conflicted about adding them as a dependency however just to copy some files. We'll see how this works out...