search

pylonweb / refinerycms-menus

Adds menus to pages, so you can create various custom menus to use on your frontend
MIT License
24 stars 30 forks source link

Add HTML id and class attributes to MenuLinks #18

Closed skipchris closed 11 years ago

skipchris commented 11 years ago

Hi Johan,

This is the change | mentioned in my email - add an id and class attribute to any menulink.

I've added a very simplistic spec to prove that it's working - and I've tested it in my own project which I need this functionality for.

Hope you don't mind, but I've tweaked the admin CSS, and added a couple of lines to the README as well. I've also removed some trailing whitespace, although this isn't intentional - my editor does it for me, but I thought it was nice to have tidier code. Feel free to just cherry-pick the functional commits if you're not interested in any of these extras!

If I've missed anything, or you're not happy with the changeset, just let me know. -Chris

jokklan commented 11 years ago

Hallo Chris, and thanks for this, it looks very nice :+1: ! However im going on vacation tomorrow, so i will properly not have time to look this through before the first week in february.

skipchris commented 11 years ago

No worries, have a great holiday! :sunny:

jokklan commented 11 years ago

Actually, after a closer look on your code, have i decided to merge anyways! It all looks great, and i can always change it later if there should be something... :) Again thank you for the contribution !