search

pylti / lti

Learning Tools Interoperability for Python
Other
78 stars 45 forks source link

PEP8 #35

Closed frankwiles closed 7 years ago

frankwiles commented 7 years ago

Was poking around in LTI to diagnose a problem and noticed a few PEP8 issues.

codecov[bot] commented 7 years ago

Codecov Report

Merging #35 into master will decrease coverage by -0.31%. The diff coverage is 73.33%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   82.67%   82.37%   -0.31%     
==========================================
  Files          13       13              
  Lines         606      607       +1     
  Branches      109      110       +1     
==========================================
- Hits          501      500       -1     
- Misses         78       79       +1     
- Partials       27       28       +1
Impacted Files Coverage Δ
src/lti/contrib/flask/flask_tool_provider.py 100% <ø> (ø) :white_check_mark:
src/lti/outcome_request.py 64.91% <ø> (ø) :white_check_mark:
src/lti/contrib/django/django_tool_provider.py 100% <ø> (ø) :white_check_mark:
src/lti/tool_consumer.py 84.37% <0%> (ø) :white_check_mark:
src/lti/tool_provider.py 89.87% <0%> (ø) :white_check_mark:
src/lti/utils.py 78.94% <100%> (ø) :white_check_mark:
src/lti/tool_base.py 92% <100%> (ø) :white_check_mark:
src/lti/launch_params.py 89.39% <60%> (-2.92%) :x:
src/lti/tool_config.py 81.67% <89.47%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e812fcd...0df2470. Read the comment docs.

ryanhiebert commented 7 years ago

Thanks! The codecov drop is just because uncovered lines were split up into multiple lines.