petarnikolovski commented 6 years ago

LTI Specs gives us option to set URL for tool's icon using <blti:icon> parameter. That parameter is already defined in ToolConfig of this library, but it's not used with to_xml() method. I've added this optional feature, updated tests, and README file to reflect the changes.

codecov[bot] commented 6 years ago

Codecov Report

Merging #57 into master will increase coverage by 1.14%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   83.71%   84.86%   +1.14%     
==========================================
  Files          16       16              
  Lines         651      654       +3     
  Branches      113      114       +1     
==========================================
+ Hits          545      555      +10     
+ Misses         78       77       -1     
+ Partials       28       22       -6

Impacted Files	Coverage Δ
src/lti/tool_config.py	`87.31% <100%> (+5.63%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 404fba5...1a3827f. Read the comment docs.

petarnikolovski commented 6 years ago

I've updated tests, and also coverage for cartridge_icon.

pylti / lti

Add icon to tool config xml #57

Codecov Report