pylti / lti

Learning Tools Interoperability for Python
Other
78 stars 45 forks source link

Fix issue with cartridge_icon parsing from xml. #58

Closed cutz closed 6 years ago

cutz commented 6 years ago

Fix tag name for cartridge_icon. Fix attribute error.

codecov[bot] commented 6 years ago

Codecov Report

Merging #58 into master will increase coverage by 0.61%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   84.86%   85.47%   +0.61%     
==========================================
  Files          16       16              
  Lines         654      654              
  Branches      114      114              
==========================================
+ Hits          555      559       +4     
+ Misses         77       75       -2     
+ Partials       22       20       -2
Impacted Files Coverage Δ
src/lti/tool_config.py 90.29% <100%> (+2.98%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 280d3ff...679125f. Read the comment docs.

cutz commented 6 years ago

Thanks!