search

pylti / lti

Learning Tools Interoperability for Python
Other
78 stars 45 forks source link

Adding oauth_token as a valid launch parameter #67

Closed jichen-amplify closed 6 years ago

jichen-amplify commented 6 years ago

Although oauth_token is not required for OAuth's Two-Legged authentication, but it is a valid oauth launch parameter. Apparently, Schoology is mandating it as part of the oauth signature. Could we add 'oauth_token' here as one of the valid launch parameters?

Thanks!

ryanhiebert commented 6 years ago

Sounds reasonable to me. Would you like to make a pull request?

jichen-amplify commented 6 years ago

Sure, I did try to push my branch to the repo first. But looks like I don't have permission to do so.

ryanhiebert commented 6 years ago

You'll have to make a fork, push your branch to your fork, then open up a pull request from that branch on your fork.

jichen-amplify commented 6 years ago

Thanks! PR is open.

jichen-amplify commented 6 years ago

@ryanhiebert When can we expect this change to be released to pypi?

ryanhiebert commented 6 years ago

Done. https://pypi.org/project/lti/0.9.4/

jichen-amplify commented 6 years ago

Awesome! Much appreciated!