search

pylti / lti

Learning Tools Interoperability for Python
Other
78 stars 45 forks source link

Handle MutableMapping deprecation warning #72

Closed tim-schilling closed 4 years ago

tim-schilling commented 4 years ago

This closes #71.

It also adds python 3.7 and 3.8 to tox and travis.

codecov[bot] commented 4 years ago

Codecov Report

Merging #72 into master will increase coverage by 0.16%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   85.88%   86.05%   +0.16%     
==========================================
  Files          16       16              
  Lines         659      667       +8     
  Branches      115      115              
==========================================
+ Hits          566      574       +8     
  Misses         74       74              
  Partials       19       19
Impacted Files Coverage Δ
src/lti/tool_config.py 92.14% <ø> (+0.05%) :arrow_up:
src/lti/launch_params.py 90.66% <100%> (+0.38%) :arrow_up:
src/lti/tool_proxy.py 100% <0%> (ø) :arrow_up:
src/lti/tool_provider.py 90.12% <0%> (+0.12%) :arrow_up:
src/lti/outcome_response.py 80.51% <0%> (+0.25%) :arrow_up:
src/lti/outcome_request.py 68.69% <0%> (+0.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87d7f9b...12edfd7. Read the comment docs.

tim-schilling commented 4 years ago

I wasn't sure if I should also change the deploy portion of Travis to use 3.7 or 3.8 so I left that alone.

ryanhiebert commented 4 years ago

Also, can you add the trove classifiers to setup.py?