pymad / cpymad

cPyMAD is a python interface to Mad-X using cython and libmadx
http://cern.ch/pymad
Apache License 2.0
3 stars 3 forks source link

Aesthetic fixes #21

Closed coldfix closed 10 years ago

coldfix commented 10 years ago

This pull request contains some minor changes to mainly setup.py. Still, you might not agree with everything: dropping distutils as an alternative to setuptools. I believe this improves stability since setuptools is needed anyways as it provides the pkg_resources module required for the resource.package module. In the spirit of failing as early as possible. Don't hesitate to drop any of the changes if you see this differently.

Furthermore, I'd like to/suggest to:

what do you think about those?

Best regards,

Thomas

Eothred commented 10 years ago

Assume this works on Windows as well (have no testing machines atm). Was not aware that you could use ~ on Windows, very practical!

coldfix commented 10 years ago

According to the expanduser documentation this is usable as a normalization between windows and unix. I had no problems on windows so far.

Eothred commented 10 years ago
coldfix commented 10 years ago

Thanks.

I just deleted the merged branches and upgraded the minor version number. Also don't forget to create a tag when updating the version number.

The src/ directory issue certainly is not top priority. Sometimes I felt like it would be more convenient and might enable testing more easily with the working-directory package without installing it system-wide. But using virtualenv for boxed installations also works fine.

Im no expert either with python packaging. Especially when it comes to non-python dependencies, there seems to be no nice standard solution available. I looked a bit into buildout and some alternatives but I did not find anything really appealing. If you don't mind I will upload a PyPI package anyway. This makes it somewhat easier to install PyMAD without needing to clone the package from git first.

Eothred commented 10 years ago

Yes, sure, go ahead and try out pypi. Note that there is already a package pymad there, so maybe you want to choose a name like cern-pymad, pymad-madx or similar.

For testing without systemwide installation, I use the PYTHONPATH environment variable. This is searched before system paths, so if set to src/build/lib.../ You will use whatever you have there. See also test/run_tests.cmake which does this automatically for the nightly builds. I think this should also work on Windows (?)

coldfix commented 10 years ago

Oh thanks! I will have a look.