search

pymad / cpymad

cPyMAD is a python interface to Mad-X using cython and libmadx
http://cern.ch/pymad
Apache License 2.0
3 stars 3 forks source link

support integer arrays in tables #50

Closed coldfix closed 10 years ago

coldfix commented 10 years ago

since r4777, get_table_column can be used to retrieve integer table columns. Currently, these are ignored, since I didn't realize that type=1 means integer array in this case as well. Since this function is quite small, we could just add the corresponding C-code to the libmadx.pyx module instead of requiring an updated MAD-X library.

I can implement this, when I have some spare time.

Eothred commented 10 years ago

Thanks!

Just to say, rest of this month I'll be rather busy and after that I'm off contract for a while. That means that if you haven't received feedback on your merge requests within ~1 week and they seem to go through testing, feel free to simply merge. "The silent man agrees" we say in Norway.

coldfix commented 10 years ago

Thanks. So I will only bring forward minor patches for now.

FYI, I have now associated a pull-request with this issue, which I don't believe should do any harm.

I also have a greater rewrite of the cpymad.madx and cpymad.model module in mind, that you should probably agree to before I simply merge it.

coldfix commented 10 years ago

Just for your information: I had this branch in testing for the last two days without any problems. I'll merge by the end of the week if you don't say anything. Hope, I'm not bothering. Best regards, Thomas