pymad / cpymad

cPyMAD is a python interface to Mad-X using cython and libmadx
http://cern.ch/pymad
Apache License 2.0
3 stars 3 forks source link

Remove recursive_history feature #62

Closed coldfix closed 10 years ago

coldfix commented 10 years ago

I don't believe the feature is very useful. It just adds a hard-to-understand parameter to the constructor of the Madx/Model classes.

The recursive_history mode makes it impossible to distinguish between commands created by PyMAD and commands contained in a CALLed file.

Furthermore, the implementation is probably still incorrect for many edge cases like multiline commands.

Eothred commented 10 years ago

The idea behind this was the following. At CERN we are often calling files which are located on a remote server. With this feature you would be able to easily generate a history file which could be executed offline. Further, with pymad we often call files from an install directory which is specific to your computer, so the history file will not be possible to use on other machines.

That said, the history files generated are huge and unmaintainable, so it was not that useful in the end (I only tried it out a couple of times).