pymad / cpymad

cPyMAD is a python interface to Mad-X using cython and libmadx
http://cern.ch/pymad
Apache License 2.0
3 stars 3 forks source link

Move models into separate repository? #69

Closed coldfix closed 9 years ago

coldfix commented 10 years ago

This was first proposed as part of #30, but will now be done separately if at all.

Restating the arguments:

Eothred commented 10 years ago

No big objections, but I see one counterargument. The model definition/structure might still evolve, in which case we would need to be careful to keep track of what kind of models are supported in a given version of the code.

This is probably anyway something we need to consider (because models can be loaded from any source as you say), so I would propose we add a key model_api or similar, or alternatively have a complete test for the model that all required items are there and optional items are understood.

coldfix commented 10 years ago

That's a valid point you raise.

Furthermore, I am not sure yet, how best to evolve the test setup to test all new cpymad commits/branches with the tests contained in the model repository. Maybe, one can setup a commit hook from the github preferences.

coldfix commented 9 years ago

Implemented in fork.