search

pymanga / pyMANGA

PYthon Models for AgeNt-based resource GAthering (pyMANGA): Describing vegetation population dynamics based on first principles
https://pymanga.forst.tu-dresden.de/
GNU General Public License v3.0
9 stars 12 forks source link

Update documentation for AG concept SimpleAsymmetricZOI #119

Closed mcwimm closed 1 year ago

mcwimm commented 3 years ago

In the documentation a reference to the tag "domain" is missing, isn't it?

Further, it would be useful to add a hint about the resolution, e.g. the number should be greater than l/resolution * 1 / 2**0.5. By the way, why do we need this min_r_crown?

@zaphod-bx what happens in case of dieback? The crown radius could fall below the threshold.

zaphod-bx commented 2 years ago

true. i suggest to change line 42 to something like min(..., 1) (I forgaß the richtige python syntax)

jvollhueter commented 2 years ago

Further, it would be useful to add a hint about the resolution, e.g. the number should be greater than l/resolution * 1 / 2**0.5.

Maybe we could add something like: Please note: The cell edge must be larger than the minimum crown diameter. Therefore must be...

jvollhueter commented 2 years ago

Further, it would be useful to add a hint about the resolution, e.g. the number should be greater than l/resolution * 1 / 2**0.5.

Maybe we could add something like: Please note: The cell edge must be larger than the minimum crown diameter. Therefore must be...

Since the documentation of the input parameters is probably one of the most important for people using pyMANGA for the first time, maybe we should note somewhere that all geometric dimensions are in meters.

mcwimm commented 1 year ago

adressed in PR #242