search

pymanga / pyMANGA

PYthon Models for AgeNt-based resource GAthering (pyMANGA): Describing vegetation population dynamics based on first principles
https://pymanga.forst.tu-dresden.de/
GNU General Public License v3.0
9 stars 12 forks source link

Salinity in different bg-concepts #81

Closed mcwimm closed 3 years ago

mcwimm commented 3 years ago

I think porewater salinity is defined in different units in different concepts: in fixedSalinity it is kg/kg and in simpleHydro it's g/kg, right? We might want to agree on one.

jbathmann commented 3 years ago

Thanks for the remark. We should stick to one definition here. As I love SI units I'd vote for ppt @zaphod-bx and @mcwimm what do you vote for?

mcwimm commented 3 years ago

I'm also for ppt. This is more intuitive.

jbathmann commented 3 years ago

Ups. I ment, that I'd like kg/kg. E.g. 35 ppt = 0.035

mcwimm commented 3 years ago

However, salinity is mostly given in ppt or psu and for mass concentrations g/kg is also common.

jbathmann commented 3 years ago

Alright. In OGS, we have to use kg/kg, but that's fine.

mcwimm commented 3 years ago

If we have to use it for ogs I'm fine with kg/kg, too. then at least it's consistent.

jbathmann commented 3 years ago

Please see PR #83. I decided to change from ppt to g/kg as it is less effort. However, I can do it the other way around, if you wish. :-)

mcwimm commented 3 years ago

Problem resolved (but ppt to kg/kg)!