search

pymc-devs / pymc-bart

https://www.pymc.io/projects/bart
Other
87 stars 17 forks source link

Update pymc version requirements.txt #163

Closed juanitorduz closed 4 months ago

juanitorduz commented 4 months ago

These are moving fast heh https://github.com/pymc-devs/pymc/releases/tag/v5.15.0

maresb commented 4 months ago

Hard pinning pymc to 5.15.0 is pretty harsh, no? I'm not following closely, but is there a particular reason?

juanitorduz commented 4 months ago

Hard pinning pymc to 5.15.0 is pretty harsh, no? I'm not following closely, but is there a particular reason?

Yes: see https://github.com/pymc-devs/pymc-bart/pull/162#issuecomment-2100243075 (and initial scope of the PR)

juanitorduz commented 4 months ago

@maresb, do you have a suggestion on how to handle this in a way to see if a new release breaks something and, if so, restrict the version?

maresb commented 4 months ago

I'd recommend a < pin to the next untested version, e.g. <5.15. Otherwise you won't be compatible with patch releases. Also, more broadly this prevents people from using it with previous versions. Is it incompatible with 5.13? If so, then it should be something like <=5.14,<5.15.

More broadly, we should do more testing.

juanitorduz commented 4 months ago

ok! Let's see :) https://github.com/pymc-devs/pymc-bart/pull/164