search

pymc-devs / pymc-data-umbrella

Website: Data Umbrella & PyMC open source sessions
https://pymc-data-umbrella.xyz/en/latest/
MIT License
26 stars 38 forks source link

mv Ricardo slides with his presentation file #202

Closed reshamas closed 1 year ago

reshamas commented 1 year ago

Ricardo's slides pdf file is in the static images folder. This PR moves it to its folder in about/contributing_to_pymc which is consistent with the other resources.

Current folder: https://pymc-data-umbrella.xyz/en/latest/_static/contributing_to_pymc_slides.pdf

New folder: https://pymc-data-umbrella.xyz/en/latest/about/contributing_to_pymc/contributing_to_pymc_slides.pdf

:books: Documentation preview pt :books:: https://pymc-data-umbrella--202.org.readthedocs.build/pt/202/

reshamas commented 1 year ago

@OriolAbril The link is broken, though I am not sure where the error is. It looks like I put the correct path in.

reshamas commented 1 year ago

@OriolAbril I don't love the idea that users have to download the pdf file. It would be nice if they could view it in their browser, which the current set-up permits. Anything we can do about that?

Screen Shot 2023-02-27 at 2 25 04 PM
OriolAbril commented 1 year ago

I don't think it is necessary to actually download the file. The download role generates a link to https://pymc-data-umbrella--202.org.readthedocs.build/en/202/_downloads/f8020df2856116faddd0ce9a59c303f1/contributing_to_pymc_slides.pdf, so the effect is basically the same as we had originally. The main difference is how the link is rendered

The ref doesn't work because it is to reference manually set targets (e.g. using the (target)= syntax). The markdown link acts as a download one because it is kind of a wildcard, with myst choosing the sphinx role that better suits (or at least what myst thinks it suits better). It doesn't add any extra functionality though