search

pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
273 stars 237 forks source link

Combine Marginalized and Latent Gaussian Mixture Notebooks? #32

Open ricardoV94 opened 3 years ago

ricardoV94 commented 3 years ago

The two notebooks are covering exactly the same issue.

They seem short enough that we could use the same dataset and show one after the other. This way we also get a chance to nudge users to try the marginalized mixture, which usually works better.

https://docs.pymc.io/notebooks/gaussian_mixture_model.html https://docs.pymc.io/notebooks/marginalized_gaussian_mixture_model.html

OriolAbril commented 3 years ago

@chiral-carbon I don't know enough about either notebook to be a good judge of whether they should be merged nor how. I'd say that if you think its doable after going over both notebooks and @ricardoV94 can help go for it, otherwise leave it for another time

chiral-carbon commented 3 years ago

okay I'll just update both to best practices for now and keep the combining part for later.

erik-werner commented 8 months ago

https://docs.pymc.io/notebooks/gaussian_mixture_model.html has since been updated to use a marginal mixture. I think https://docs.pymc.io/notebooks/marginalized_gaussian_mixture_model.html is therefore basically redundant, and I would propose to delete it.