pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
269 stars 234 forks source link

Updated tag to Generalised linear model #432

Closed BerylKanali closed 1 year ago

BerylKanali commented 1 year ago

Towards https://github.com/pymc-devs/pymc-examples/issues/430 and https://github.com/pymc-devs/pymc-examples/issues/431

I updated the tag "generalized linear models" and "generalized linear model" as recommended by @reshamas

cc: @reshamas

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

reshamas commented 1 year ago

@BerylKanali Can you also update the tag in the myst file? https://github.com/pymc-devs/pymc-examples/blob/main/myst_nbs/generalized_linear_models/GLM-model-selection.myst.md

BerylKanali commented 1 year ago

@BerylKanali Can you also update the tag in the myst file? https://github.com/pymc-devs/pymc-examples/blob/main/myst_nbs/generalized_linear_models/GLM-model-selection.myst.md

Made a commit on that.

reshamas commented 1 year ago

@OriolAbril @cluhmann Would you know if it's required to run pre-commit?

I was wondering if it was possible to make a minor change to both the notebook and myst file without rerunning it.

twiecki commented 1 year ago

myst always causes problem. The easiest is to delete the myst file locally and then run precommit to recreate it, commit the ipynb and myst file, and push.

cluhmann commented 1 year ago

@OriolAbril @cluhmann Would you know if it's required to run pre-commit?

I was wondering if it was possible to make a minor change to both the notebook and myst file without rerunning it.

I think that is possible. But jupytext will often make changes to notebook (or rather to the corresponding myst files) that you may not expect (e.g., changes to the metadata that you didn't change by hand). So going in to just change a typo (or whatever) creates more changes that you "see".