pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
282 stars 244 forks source link

notebook: glm-model-selection, bambi import error #433

Open reshamas opened 2 years ago

reshamas commented 2 years ago

Notebook title: GLM Model Selection Notebook url: https://github.com/pymc-devs/pymc-examples/blob/main/examples/generalized_linear_models/GLM-model-selection.ipynb Note: it is using pymc3

Issue description

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Input In [1], in <cell line: 2>()
      1 import arviz as az
----> 2 import bambi as bmb
      3 import matplotlib.pyplot as plt
      4 import numpy as np

ModuleNotFoundError: No module named 'bambi'

Expected output

The notebook should run without error.

Proposed solution

Do the requirements file need to be updated to install bambi?

  1. https://github.com/pymc-devs/pymc-examples/blob/main/requirements-write.txt
  2. https://github.com/pymc-devs/pymc-examples/blob/main/requirements-docs.txt
OriolAbril commented 2 years ago

We should not update the requirements file but instead add a note about the need for libraries that are not pymc dependencies: https://docs.pymc.io/en/latest/contributing/jupyter_style.html#extra-dependencies