Closed drbenvincent closed 1 year ago
Yes, way way better.
I would only use group
argument when we want to get variables that are not in the posterior group. We set this default because getting variables from the posterior is the most common operation and it is convenient to skip it
Lines like this represent a common pattern across many notebooks in the repo:
This is basically some
xarray
stuff to get a 'flat' vector of MCMC samples by collapsing over chain and draws. But it is arguably unclear, opaque, and potentially frustrating to many users.I propose we use the new(ish)
arviz.extract
function instead. So we would end up with something like this, which is much much clearer to a wide range of pymc users.Tagging @twiecki and @OriolAbril for any thoughts