GLM-robust update - Githubissues

pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.

https://www.pymc.io/projects/examples/en/latest/

MIT License

282 stars 244 forks source link

GLM-robust update #451

Closed kuvychko closed 1 year ago

kuvychko commented 1 year ago

Tracker Issue #88

Summary of changes:

Updated links to Thomas's blog posts (old links were obsolete/broken)
Changed code that uses pm.plot_posterior_predictive_glm since this method is no longer in pymc
- I experimented with arviz.plot_lm but couldn't get a comparable plot
- Instead, I explicitly computed and plotted a subset of regression lines using coefficients from posterior. Personally I think it is helpful to have an example of a more explicit calculation/visualization like that.
Updated link to Kruschke's "puppy" book since the link to U of Indiana no longer works. Instead I put a link to Elsevier's book page.
Updated rv.logp(x) method to pm.logp(rv, x) since the original method was removed
Added Authors section at the end of the notebook

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

kuvychko commented 1 year ago

@OriolAbril @reshamas - it looks like this change hasn't been reviewed yet (I filed this PR 16 days ago). clearly no rush with this, but I want to make sure it doesn't fall through the cracks. Thanks!

OriolAbril commented 1 year ago

We currently have 3 PRs open for this same notebook: #356, #445, #451. And I am not sure how to go about this, git conflicts on notebooks are a nightmare. I might try to merge the myst and then update the notebook from it which might happen in a 4th PR overriding the current 3. I will take a look and work on this next week. Thank you all for the PRs, I'll make sure at the very least you are listed as co-author in the merged PR.

kuvychko commented 1 year ago

@OriolAbril - ouch, I see! That's unfortunate, my apologies that it took me so long to finish with it!

reshamas commented 1 year ago

@kuvychko Can you send me the email address you use for GitHub, so @OriolAbril can add you as a co-author on the GLM-robust notebook?

OriolAbril commented 1 year ago

Superseded by https://github.com/pymc-devs/pymc-examples/pull/472

kuvychko commented 1 year ago

@reshamas - sure thing, igor.kuvychko@gmail.com

Thanks!!