Closed danhphan closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
View / edit / reply to this conversation on ReviewNB
twiecki commented on 2022-10-31T08:32:13Z ----------------------------------------------------------------
I would not add kronecker to tags.
danhphan commented on 2022-11-03T07:39:30Z ----------------------------------------------------------------
Hi, yes sure, I will remove it.
I may wait a bit for further comments/feedbacks, and will update these suggestions in one shot. Thanks!
Hi, yes sure, I will remove it.
I may wait a bit for further comments/feedbacks, and will update these suggestions in one shot. Thanks!
View entire conversation on ReviewNB
Hi, I have updated the notebook. Need one more reviewer please. Thank you!
View / edit / reply to this conversation on ReviewNB
bwengals commented on 2022-11-07T23:10:30Z ----------------------------------------------------------------
For the first mentions of each of the GP classes, gp.Marginal
,gp.Latent
,gp.MarginalKron
and gp.LatentKron
, it would be good to format them like this: "{class}gp.Latent <pymc.gp.Latent>
" (without the "s) so they link to the documentation. ,
View / edit / reply to this conversation on ReviewNB
bwengals commented on 2022-11-07T23:10:31Z ----------------------------------------------------------------
@oriolabril suggested I use this format for the watermark line on a different notebook:
python
%watermark -n -u -v -iv -w -p aesara,aeppl,xarray
Thanks Bill, I have updated the links of GP classes and watermark :)
Hi, thanks @OriolAbril. The authors and watermark of this notebook have been updated.
This PR updates the GP Kron notebook from PyMC3 to PyMC version 4. It addresses the issue https://github.com/pymc-devs/pymc-examples/issues/71.
Cc @bwengals and @OriolAbril
Thank you.