search

pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
269 stars 234 forks source link

Update GP Kron notebook with PyMC version 4 #455

Closed danhphan closed 1 year ago

danhphan commented 1 year ago

This PR updates the GP Kron notebook from PyMC3 to PyMC version 4. It addresses the issue https://github.com/pymc-devs/pymc-examples/issues/71.

Cc @bwengals and @OriolAbril

Thank you.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-10-31T08:32:13Z ----------------------------------------------------------------

I would not add kronecker to tags.


danhphan commented on 2022-11-03T07:39:30Z ----------------------------------------------------------------

Hi, yes sure, I will remove it.

I may wait a bit for further comments/feedbacks, and will update these suggestions in one shot. Thanks!

danhphan commented 1 year ago

Hi, yes sure, I will remove it.

I may wait a bit for further comments/feedbacks, and will update these suggestions in one shot. Thanks!

View entire conversation on ReviewNB

danhphan commented 1 year ago

Hi, I have updated the notebook. Need one more reviewer please. Thank you!

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

bwengals commented on 2022-11-07T23:10:30Z ----------------------------------------------------------------

For the first mentions of each of the GP classes, gp.Marginal,gp.Latent,gp.MarginalKron and gp.LatentKron , it would be good to format them like this: "{class}gp.Latent <pymc.gp.Latent>" (without the "s) so they link to the documentation. ,


review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

bwengals commented on 2022-11-07T23:10:31Z ----------------------------------------------------------------

@oriolabril suggested I use this format for the watermark line on a different notebook:

python

%watermark -n -u -v -iv -w -p aesara,aeppl,xarray


danhphan commented 1 year ago

Thanks Bill, I have updated the links of GP classes and watermark :)

danhphan commented 1 year ago

Hi, thanks @OriolAbril. The authors and watermark of this notebook have been updated.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.