pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
269 stars 234 forks source link

Correct definition of nu and assign lower value for sigma_low #459

Closed hyosubkim closed 1 year ago

hyosubkim commented 1 year ago

With suggested changes, results will more closely align with Kruschke paper, which example is based on.

{Insert Description}

Helpful links

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

OriolAbril commented 1 year ago

Thanks, can you run pre-commit?

It should be something like:

pip install pre-commit # or conda or local install
pre-commit run --all

which should update the .myst.md file. Then commit and push and all checks should pass hopefully

hyosubkim commented 1 year ago

I did as suggested and pushed the changes. Hope it went through okay this time.

OriolAbril commented 1 year ago

Thanks! This got both CI jobs to pass

hyosubkim commented 1 year ago

Great! Thanks again for your help