Closed ghost closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
So far I only skimmed but this looks excellent. Still need to solve pre-commit issues with the myst files.
Pre-commit issues fixed.
View / edit / reply to this conversation on ReviewNB
twiecki commented on 2022-11-25T14:46:17Z ----------------------------------------------------------------
Can we add axis labels?
fonnesbeck commented on 2022-11-25T22:56:19Z ----------------------------------------------------------------
Added.
View / edit / reply to this conversation on ReviewNB
twiecki commented on 2022-11-25T14:46:18Z ----------------------------------------------------------------
Curious why these look so different from before.
fonnesbeck commented on 2022-11-25T16:29:36Z ----------------------------------------------------------------
Probably a function of the odd parameterization that is in the current version (assuming floor and basement are independent). This revision matches what you see in Gelman.
View / edit / reply to this conversation on ReviewNB
twiecki commented on 2022-11-25T14:46:19Z ----------------------------------------------------------------
You could link to my blog post where I go into more detail: https://twiecki.io/blog/2017/02/08/bayesian-hierchical-non-centered/
fonnesbeck commented on 2022-11-25T22:58:56Z ----------------------------------------------------------------
Added a link.
View / edit / reply to this conversation on ReviewNB
twiecki commented on 2022-11-25T14:46:20Z ----------------------------------------------------------------
You could also mention somewhere that instead of a hierchical model, we can place geospatial distribution over the counties radon levels like here: https://www.pymc-labs.io/blog-posts/spatial-gaussian-process-01/
fonnesbeck commented on 2022-11-25T23:02:36Z ----------------------------------------------------------------
Added a link.
Probably a function of the odd parameterization that is in the current version (assuming floor and basement are independent). This revision matches what you see in Gelman.
View entire conversation on ReviewNB
Great stuff, this classic is in great shape now!
This is an update to the multilevel modeling notebook that makes two main changes:
I am also removing the
GLM-hierarchical
notebook, as it is almost completely redundant with this one, now that it no longer uses the extinctglm
submodule.