pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.

https://www.pymc.io/projects/examples/en/latest/

MIT License

282 stars 244 forks source link

[DRAFT] Notebook: GLM out-of-sample; initial update #471

Closed reshamas closed 1 year ago

reshamas commented 1 year ago

References

Towards #394
Towards #460
References pymc-devs/pymc #5460 (Update example gallery style and formatting)
References Project Board: https://github.com/pymc-devs/pymc-examples/projects/1
[x] Notebook follows style guide https://docs.pymc.io/en/latest/contributing/jupyter_style.html
[x] PR description contains a link to the relevant issue: a tracker one for existing notebooks or a proposal one for new notebooks
[x] Check the notebook is not excluded from any pre-commit check: https://github.com/pymc-devs/pymc-examples/blob/main/.pre-commit-config.yaml

Helpful links

https://github.com/pymc-devs/pymc-examples/blob/main/CONTRIBUTING.md

Notes for the Reviewer

This notebook is being removed because the module GLM is no longer being used in pymc v4.
See https://github.com/pymc-devs/pymc-examples/issues/460

DataUmbrellaPyMCSprint

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

twiecki commented 1 year ago

Missing the myst file.

twiecki commented 1 year ago

Actually as this uses the GLM submodule exclusively, which does not exist anymore, we should probably just get rid of this NB.

reshamas commented 1 year ago

@twiecki The notebook still works with pymc v3.

Should we open up an issue to create a new notebook for pymc v4 with an out-of-sample example?

twiecki commented 1 year ago

I don't think we need to invest in v3 docs.

We have https://www.pymc.io/projects/examples/en/latest/howto/data_container.html#using-data-container-variables-to-predict-on-new-data so I think it's fine.

reshamas commented 1 year ago

Note to self: delete the notebook and submit a PR.

reshamas commented 1 year ago

@twiecki Trying to figure out how to relate issue #460 to this PR.

cc: @juanitorduz @drbenvincent

juanitorduz commented 1 year ago

hey! there was an updated version of this notebook :) See https://github.com/pymc-devs/pymc-examples/issues/460#issuecomment-1341047607

OriolAbril commented 1 year ago

This is something users struggle with a lot, so I'd aim for keeping the v4 version of this notebook

drbenvincent commented 1 year ago

I've brought back the v3 -> v4 conversion that I did this summer. It got removed by accident, see #460 for more details. I've run this using pymc 5.0.1 now, so probably recommend we close this in favour of #486.

drbenvincent commented 1 year ago

486 is merged now, so closing this