thumbnails not showing on notebooks home page

[reshamas]

Notebook title: Notebook url:

Thumbnails are not showing here: https://www.pymc.io/projects/examples/en/latest/gallery.html

[twiecki]

Probably due to https://github.com/pymc-devs/brand/pull/21

[reshamas]

Arrgh! Disliking breaking changes. :(

[drbenvincent]

These notebooks exist here https://github.com/pymc-devs/pymc/tree/main/docs/source/learn/core_notebooks rather than in the pymc-examples repo. Personally I think this creates a bit of added complexity. What do people think about moving them into the pymc-examples repo?

I think the logic of having them in pymc-devs/pymc was to make sure that these are always up to date with the latest API. But I think we can just achieve the same result if we treat these as 'core' and of high importance, but in the pymc-examples repo.

What do people think?

[twiecki]

That makes sense to me.

On Wed, Dec 28, 2022, 13:02 Benjamin T. Vincent @.***> wrote:

These notebooks exist here https://github.com/pymc-devs/pymc/tree/main/docs/source/learn/core_notebooks rather than in the pymc-examples repo. Personally I think this creates a bit of added complexity. What do people think about moving them into the pymc-examples repo?

I think the logic of having them in pymc-devs/pymc was to make sure that these are always up to date with the latest API. But I think we can just achieve the same result if we treat these as 'core' and of high importance, but in the pymc-examples repo.

What do people think?

— Reply to this email directly, view it on GitHub https://github.com/pymc-devs/pymc-examples/issues/479#issuecomment-1366600389, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFETGFDBF7MAMD2ZP6G2RDWPQT6TANCNFSM6AAAAAATDTK4PE . You are receiving this because you commented.Message ID: @.***>

[OriolAbril]

trying to think about the workflow to ensure the core notebooks are always up to date with the codebase I find it more complicated. I am not sure users know or even care the page they go to when they click on those first cards are generated from a different repo.

How do you envision the updated workflow to be?

For comparison, he current one is any time a change breaks a core notebook, CI fails for that PR and the notebook is updated in the same PR that modified the related code. Every PR and every build on latest execute all core notebooks on the corresponding local github version.

[ricardoV94]

I think it makes sense for the core notebooks to work as they do now. It must be possible to fix the thumbnails some other way.

[OriolAbril]

Thumbnails are already fixed by the way, we just forgot to close the issue

[reshamas]

Closed by https://github.com/pymc-devs/pymc-examples/pull/480