pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
263 stars 218 forks source link

Bring back updated GLM out of sample prediction notebook #486

Closed drbenvincent closed 1 year ago

drbenvincent commented 1 year ago

The GLM out of sample notebook by @juanitorduz (originally in PyMC 3) was previously updated by me to v4. This accidentally got removed though. See #460 for more details.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

juanitorduz commented 1 year ago

Awesome 🙌!

drbenvincent commented 1 year ago

Maybe we can simply remove all reference to the GLM submodule now?

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-12-28T15:36:37Z ----------------------------------------------------------------

Is this all with subheading? Looks a bit big.


OriolAbril commented on 2022-12-28T15:42:46Z ----------------------------------------------------------------

reviewnb can't be used for checking rendering issues, here is how it actually looks: https://pymcio--486.org.readthedocs.build/projects/examples/en/486/generalized_linear_models/GLM-out-of-sample-predictions.html