search

pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
263 stars 218 forks source link

notebook: Bayes Factor (run with pymc v5) #490

Closed reshamas closed 1 year ago

reshamas commented 1 year ago

Description

Run Bayes Factor notebook with PyMC version 5.

NOTE: needed to set progressbar=False to avoid errors.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

cluhmann commented 1 year ago

Is there an issue open for the progressbar problem?

reshamas commented 1 year ago

Is there an issue open for the progressbar problem?

No. @OriolAbril said it was specific to this notebook, not a general problem.

OriolAbril commented 1 year ago

There is an issue: https://github.com/pymc-devs/pymc/issues/5855 we already commented there, but it is not clear how to reproduce the issue so it hasn't been fixed.

cluhmann commented 1 year ago

Got it. Just wanted to make sure it was being referenced here if the issue already existed. But now it is!

OriolAbril commented 1 year ago

I have re-executed the notebook locally to see if I could reproduce the issue, but I didn't, in my case it worked, so the issue will continue to be open and with no solution in sight. I have pushed so we can merge without needing to remove the progressbar in sample_smc