pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
280 stars 243 forks source link

Update ModelBuilder to show regression lines #538

Closed BerylKanali closed 1 year ago

BerylKanali commented 1 year ago

@cluhmann Here is the PR from yesterday's session. I worked on it with @Monsurat-Onabajo

Towards https://github.com/pymc-devs/pymc-examples/issues/530 cc: @fonnesbeck @reshamas

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

twiecki commented 1 year ago

We also recently changed the API of ModelBuilder (slightly), are you interested in bringing this example up-to-date? Here is the PR: https://github.com/pymc-devs/pymc-experimental/pull/131

Monsurat-Onabajo commented 1 year ago

When I tried to plot the graph of the truth values and the predicted values in one figure, I got this graph and upon investing further, I noticed the truth value data is more of a wavelength dataset than a regression dataset. That was probably the reason a line can't be used as a connector because there is no pattern in the data for the graph to be formed on.

20230403_215738~2

Monsurat-Onabajo commented 1 year ago

This was when I tried to plot the true value using scattered plot to check the trend 16806072262584167303588619519001

twiecki commented 1 year ago

@Monsurat-Onabajo The upload didn't work, you might have to wait a bit longer.

Monsurat-Onabajo commented 1 year ago

@Monsurat-Onabajo The upload didn't work, you might have to wait a bit longer.

I have uploaded it again

OriolAbril commented 1 year ago

@Monsurat-Onabajo @BerylKanali if you don't mind waiting we can take a look this Thursday, maybe it is easier to solve in the sync session

BerylKanali commented 1 year ago

@Monsurat-Onabajo @BerylKanali if you don't mind waiting we can take a look this Thursday, maybe it is easier to solve in the sync session

@OriolAbril Sure. We can look at it then.

BerylKanali commented 1 year ago

@fonnesbeck I made additional changes with the guidance of @OriolAbril cc: @Monsurat-Onabajo

Monsurat-Onabajo commented 1 year ago

@fonnesbeck I made additional changes with the guidance of @OriolAbril cc: @Monsurat-Onabajo

Goodjob beryl