Bugfix of cutpoint calculations in ordinal regression notebook

[fonnesbeck]

The function constrainedDirichlet in the ordinal regression notebook tries to min-max scale the cutpoints using the formula x * (min + (max - min)), which only works as intended for min=0. By inspection this just simplifies to x * max. The correct formula should be x * (max - min) + min. This is corrected in this PR.

To make the merge process smoother we've provided some links and a checklist below.

We understand that PRs can sometimes be overwhelming, especially as the reviews start coming in. Please let us know if the reviews are unclear or the recommended next step seems overly demanding, if you would like help in addressing a reviewer's comments, or if you have been waiting too long to hear back on your PR. -->

• [x] Notebook follows style guide https://docs.pymc.io/en/latest/contributing/jupyter_style.html
• [x] PR description contains a link to the relevant issue:
  • a tracker one for existing notebooks (tracker issues have the "tracker id" label)
  • or a proposal one for new notebooks
• [x] Check the notebook is not excluded from any pre-commit check: https://github.com/pymc-devs/pymc-examples/blob/main/.pre-commit-config.yaml

Helpful links

• https://github.com/pymc-devs/pymc-examples/blob/main/CONTRIBUTING.md

---

:books: Documentation preview :books:: https://pymc-examples--564.org.readthedocs.build/en/564/

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB