pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
259 stars 211 forks source link

Update notebook GLM-negative-binomial-regression to pymc v5 #573 #575

Closed wesleyboelrijk closed 7 months ago

wesleyboelrijk commented 9 months ago

Description

Issue

573

The notebook GLM-negative-binomial-regression was still using PyMC v4. I have updated it to PyMC v5. Besides that, there is a dependency on seaborn, which was not listed in requirements-docs.txt. I have added this. Lastly, seaborn gave a bunch of FutureWarnings upon plotting in the notebook. I added a warning suppression for those FutureWarnings.

Screenshot 2023-09-16 at 15 59 13

Helpful links


:books: Documentation preview :books:: https://pymc-examples--575.org.readthedocs.build/en/575/

review-notebook-app[bot] commented 9 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

wesleyboelrijk commented 9 months ago

Hi @wesleyboelrijk. Thanks for the contribution! Looks great, but I just left a few minor change requests.

Thanks @drbenvincent and @OriolAbril for the feedback! I made the requested changes. Let me know if any other changes are required :)