pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
259 stars 211 forks source link

Update example notebook for mediation analysis to correct package name to PyMC #574 #576

Open asarjou opened 9 months ago

asarjou commented 9 months ago

574

Updating the mediation_analysis notebook to update the markdown to correct the package name.

When rerunning the notebook, seaborn raised some Future warnings which were suppressed using the warnings package

Helpful links


:books: Documentation preview :books:: https://pymc-examples--576.org.readthedocs.build/en/576/

review-notebook-app[bot] commented 9 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

OriolAbril commented 9 months ago

I'm not sure if there's a specific policy about suppression of warnings. If it's easy to update the arviz calls to avoid those (and need for warning suppression) then that would be ideal. Any thoughts @OriolAbril?

Warnings should be fixed instead of ignored. Only if there are some issues with trying to fix it (e.g. needing a dependency to be updated or a release to happen) they should be ignored.

@asarjou if you share the complete warning you got from seaborn we might be able to help with its fix.

OriolAbril commented 9 months ago

Saw some seaborn warnings in a different PR. Using the latest release candidate should fix them if they are the same: https://github.com/mwaskom/seaborn/releases/tag/v0.13.0rc0