Update notebook Dirichlet mixture of multinomials to PyMC 5

[erik-werner]

Issue #100

• [x] Notebook follows style guide https://docs.pymc.io/en/latest/contributing/jupyter_style.html
• [x] PR description contains a link to the relevant issue:
  • a tracker one for existing notebooks (tracker issues have the "tracker id" label)
  • or a proposal one for new notebooks
• [x] Check the notebook is not excluded from any pre-commit check: https://github.com/pymc-devs/pymc-examples/blob/main/.pre-commit-config.yaml

---

:books: Documentation preview :books:: https://pymc-examples--581.org.readthedocs.build/en/581/

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

ricardoV94 commented on 2023-10-05T10:56:08Z ----------------------------------------------------------------

We should pass rng to .rvs(random_state=rng so the data is fixed.

erik-werner commented on 2023-10-05T11:15:08Z ----------------------------------------------------------------

Yep, I had actually just fixed this when I saw your comment :)

I'm working on some more updates, so it might be good to hold off on reviewing the rest of the notebook for now.

erik-werner commented 9 months ago

Yep, I had actually just fixed this when I saw your comment :)

I'm working on some more updates, so it might be good to hold off on reviewing the rest of the notebook for now.

---

View entire conversation on ReviewNB

erik-werner commented 9 months ago

pre-commit is failing.

But the errors are unrelated to my changes:

black-jupyter.................................................................................Failed
- hook id: black-jupyter
- files were modified by this hook

reformatted examples/case_studies/nyc_bym.ipynb
reformatted examples/howto/model_builder.ipynb

All done! ✨ 🍰 ✨
2 files reformatted, 129 files left unchanged.

Shall I fix them as part of this pull request anyway? It's easily done. Or do you want me to open a new pull request where I fix these errors?

twiecki commented 9 months ago

@erik-werner Ah, in that case you can:

1. just don't do anything and we merge
2. fix it here
3. don't fix it here and do a separate PR

Which do you prefer?

erik-werner commented 9 months ago

@twiecki I'll fix it here then!

twiecki commented 9 months ago

Thanks @erik-werner, this is a great contribution!

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[erik-werner]

Yep, I had actually just fixed this when I saw your comment :)

I'm working on some more updates, so it might be good to hold off on reviewing the rest of the notebook for now.

---

View entire conversation on ReviewNB

[erik-werner]

pre-commit is failing.

But the errors are unrelated to my changes:

black-jupyter.................................................................................Failed
- hook id: black-jupyter
- files were modified by this hook

reformatted examples/case_studies/nyc_bym.ipynb
reformatted examples/howto/model_builder.ipynb

All done! ✨ 🍰 ✨
2 files reformatted, 129 files left unchanged.

Shall I fix them as part of this pull request anyway? It's easily done. Or do you want me to open a new pull request where I fix these errors?

[twiecki]

@erik-werner Ah, in that case you can:

1. just don't do anything and we merge
2. fix it here
3. don't fix it here and do a separate PR

Which do you prefer?

[erik-werner]

@twiecki I'll fix it here then!

[twiecki]

Thanks @erik-werner, this is a great contribution!