search

pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
280 stars 243 forks source link

Update SMC-ABC_Lotka-Volterra_example.ipynb #590

Closed PRKramer closed 10 months ago

PRKramer commented 10 months ago

588 Added the time array to the plots to correctly represent the independent variable in 2 plots

Helpful links

:books: Documentation preview :books:: https://pymc-examples--590.org.readthedocs.build/en/590/

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

OriolAbril commented 10 months ago

Thanks for the PR. You should also rerun the notebook and then run pre-commit

PRKramer commented 10 months ago

Sorry I am really naive about python and GitHub. I just noticed the error in the notebook when I was adopting the material for use in a math class. I can't even figure outhow to run python on my modified notebook, nor how to download the notebook onto my computer. I just modified the syntax of the plot commands in a way that worked when I did it on a private notebook. I don't expect you to give me a tutorial on pull requests, nor do I want to read a massive amount of documentation. I just wanted to point out a small error in the example notebook which should be very simple to fix for someone who understands the GitHub process better than I do...I'm happy to abandon the issue if it's more bother than it's worth.

PRKramer commented 10 months ago

Wait..one of my students in my class figured out how to overcome the check failure...working on it!

MacroLens commented 10 months ago

@OriolAbril reran the notebook and ran pre-commit on changes. Let me know if there is anything else you need.

review-notebook-app[bot] commented 10 months ago

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2023-11-17T07:57:01Z ----------------------------------------------------------------

This doesn't look correct.


MacroLens commented on 2023-11-17T16:20:18Z ----------------------------------------------------------------

You would be correct. I'm fixing it now, the time scale wasn't applied to the plot on line 6.

MacroLens commented on 2023-11-17T16:49:14Z ----------------------------------------------------------------

Looks better now.

PRKramer commented 10 months ago

I was flying blind because I didn't see how to actually run the change. Dylan reminded me about cloning (yes, it's been a few years since my last GitHub encounter with some research students, which sent me fleeing). So I'll give it a closer look when I have a bit of time to walk through the mechanics.

MacroLens commented 10 months ago

You would be correct. I'm fixing it now, the time scale wasn't applied to the plot on line 6.

View entire conversation on ReviewNB

review-notebook-app[bot] commented 10 months ago

View / edit / reply to this conversation on ReviewNB

MacroLens commented on 2023-11-17T16:48:38Z ----------------------------------------------------------------

Should I suppress or correct the warnings?


MacroLens commented 10 months ago

Looks better now.

View entire conversation on ReviewNB

twiecki commented 10 months ago

Thanks!

Fxinyu commented 10 months ago

Hi, I have encountered this problem. Do you have any insights on this situation? I would appreciate that you could reply to me. Screenshot 2023-11-23 102841

twiecki commented 10 months ago

Are other models sampling fine?

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.