pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
259 stars 211 forks source link

Update HSGP with changes from PyMC #7342 #665

Closed bwengals closed 3 weeks ago

bwengals commented 1 month ago

📚 Documentation preview 📚: https://pymc-examples--665.org.readthedocs.build/en/665/

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

review-notebook-app[bot] commented 1 month ago

View / edit / reply to this conversation on ReviewNB

AlexAndorra commented on 2024-06-02T16:17:04Z ----------------------------------------------------------------

Line #12.    X_center = (np.max(X, axis=0) - np.min(X, axis=0)) / 2.0

IIUC, this is computing the radius, not the mid point. For the latter, I think, we need to change the formula to:

X_center = (np.max(X, axis=0) + np.min(X, axis=0)) / 2