search

pymc-devs / pymc-examples

Examples of PyMC models, including a library of Jupyter notebooks.
https://www.pymc.io/projects/examples/en/latest/
MIT License
287 stars 245 forks source link

Images in NBs are compressed #671

Open twiecki opened 3 months ago

twiecki commented 3 months ago

Images in NBs are compressed, this is a sphinx issue that popped up e.g. here: https://github.com/pymc-labs/pymc-marketing/pull/667

twiecki commented 3 months ago

Oh, supposedley it was fixed in https://github.com/pymc-devs/pymc-examples/pull/660 but still seeing it here: https://www.pymc.io/projects/examples/en/latest/gaussian_processes/HSGP-Advanced.html

image
twiecki commented 3 months ago

Oh, I accidentally committed the fix to main https://github.com/pymc-devs/pymc-examples/commit/1258d5fd90786c762dfb3a596e811acc78ca6af7. Anyway that hopefully takes care of it. The issue is, I'm fairly certain, that myst-nb released 1.1.1 with the bug still present.

OriolAbril commented 3 months ago

The fix was definitely merged before the release 🤔. But there were a couple PRs to fix it that were merged together, maybe something went wrong. I'll reopen so we remember to check

OriolAbril commented 3 months ago

I re-rendered the mwe I generated for the issues and I don't see any problem with myst-nb 1.1.1: https://oriol-sphinx-playground.readthedocs.io/en/image_metadata_a/.

I'll open a PR to see if 1) the PR preview renders correctly, 2) it is using the right versions