Closed twiecki closed 10 months ago
This involves moving everything in utils.model_fgraph
and model_transform
. It probably makes sense to make a submodule model
in pymc instead of the single pymc.model.py
file that currently exists
I want to support this initiative. The idea is to create a model
submodule and have:
model
|-- model.py (this will imply a lot of paths refactors done automatically)
|--model_transform.py (from pymc experimental)
|--utils
|----model_fgraph.py (from pymc experimental)
Plus, adding tests?
@juanitorduz That's great! @ricardoV94 will know but it looks correct to me. We should probably find better names for the files though.
I want to support this initiative. The idea is to create a
model
submodule and have:model |-- model.py (this will imply a lot of paths refactors done automatically) |--model_transform.py (from pymc experimental) |--utils |----model_fgraph.py (from pymc experimental)
The utils
isn't needed, just put model_fgraph.py
inside the model
module.
Plus, adding tests?
All functionality is already tested here, so you just need to port the tests.
Ok! I gave it a shot in https://github.com/pymc-devs/pymc/pull/6879 . I hope I did not mess up anything (do not trust me hehe)
We need to remove it from pymc-experimental now that it's in PyMC
Description
@ricardoV94 said that things have stabilized enough to where we can port it to pymc proper. Code can be found here: https://github.com/pymc-devs/pymc-experimental/blob/main/pymc_experimental/model_transform/conditioning.py