search

pymc-devs / pymc-experimental

https://pymc-experimental.readthedocs.io
Other
72 stars 46 forks source link

Implement BetaNegativeBinomial distribution #258

Closed wd60622 closed 8 months ago

wd60622 commented 8 months ago

Closes this issue

wd60622 commented 8 months ago

Doc rendering

Screenshot 2023-11-03 at 17 52 58
wd60622 commented 8 months ago

Docs with an image

latest-rendering
wd60622 commented 8 months ago

Thanks for the review @ricardoV94, the implementation mirrors Chi for distribution as well as the tests. Super cool, thanks for the suggestion. Are those tests sufficient? Are checks for the domain of the random variable or the domains of the parameters? Especially with the switch statement?

ricardoV94 commented 8 months ago

Are checks for the domain of the random variable or the domains of the parameters? Especially with the switch statement?

Yeah, check_logp covers that

ricardoV94 commented 8 months ago

You have a pre-commit failure. The failing test is unrelated and should go away when we rerun them

wd60622 commented 8 months ago

I realized I didn't put Skellam or this distribution in the __all__ of __init__.py

wd60622 commented 8 months ago

Thanks for the feedback. I think that everything has been added in