search

pymc-devs / pymc-experimental

https://pymc-experimental.readthedocs.io
Other
72 stars 46 forks source link

Add `@as_model` decorator #268

Closed theorashid closed 7 months ago

theorashid commented 7 months ago

Also move marginal_model into pymc_experimental/model. Hopefully I reorganised the file structure correctly

cc: @ricardoV94 @zaxtax @twiecki

ricardoV94 commented 7 months ago

Just a bit worried about name clash between the module model and the decorator model? What about calling the decorator as_model?

ricardoV94 commented 7 months ago

The URL in the docstrings doesn't seem to render correctly: https://pymcio--268.org.readthedocs.build/projects/experimental/en/268/generated/pymc_experimental.model.html

zaxtax commented 7 months ago

Just a bit worried about name clash between the module model and the decorator model? What about calling the decorator as_model?

Have there been bugs or issues due to this kind of name clash before?

ricardoV94 commented 7 months ago

Have there been bugs or issues due to this kind of name clash before?

We had some issues with docs in the past, when a function had the same name as the module

theorashid commented 7 months ago

hopefully all good to go now

twiecki commented 7 months ago

Would be nice to give @zaxtax some credit here, commit co-author?

ricardoV94 commented 7 months ago

Thanks @theorashid