search

pymc-devs / pymc-experimental

https://pymc-experimental.readthedocs.io
Other
72 stars 46 forks source link

Adapt PyMC 5.10.0 breaking changes #272

Closed HasnainRaz closed 7 months ago

HasnainRaz commented 7 months ago

Changing the name to reflect the renaming in https://github.com/pymc-devs/pymc/commit/04a03b520aa52c5586123f076c6377b32cf855b4

Otherwise importing this module raises an import error.

This need not be merged now, I am just making this PR to use the commit in my dependencies without relying on my own fork.

ricardoV94 commented 7 months ago

@HasnainRaz did it fail or just raise a warning. The idea was that the old name was still importable but with a warning

https://github.com/pymc-devs/pymc/blob/04a03b520aa52c5586123f076c6377b32cf855b4/pymc/distributions/transforms.py#L63-L65

ricardoV94 commented 7 months ago

Ahh this was importing from the right place: logprob submodule. The warning was added in the user facing one... makes sense maybe

HasnainRaz commented 7 months ago

It was failing

ricardoV94 commented 7 months ago

We can now lower pin pymc to the 5.10.0 version that was just released. That is the one with the breaking change here. The tests should start passing as well (we always test against the latest release)

twiecki commented 7 months ago 
      from pymc.pytensorf import local_remove_check_parameter

E ImportError: cannot import name 'local_remove_check_parameter' from 'pymc.pytensorf' (/usr/share/miniconda3/envs/pymc-experimental-test/lib/python3.9/site-packages/pymc/pytensorf.py)

HasnainRaz commented 7 months ago

@ricardoV94 Seems the tests are failing because of a missing function in pymc. I lack the context to fix this, if you guys wanna push to this PR, feel free to do so