pymc-devs / pymc-experimental

https://pymc-experimental.readthedocs.io
Other
77 stars 49 forks source link

Use model variables named "sigma" as standard deviations rather than variances #296

Closed jessegrabowski closed 9 months ago

jessegrabowski commented 9 months ago

Closes #295

Variables named "sigma" in structural models, as well as SARIMAX, were being directly inserted into the state/observation covariance matrix as-is. This implies they are variances, while the name "sigma" suggests they are standard deviations.

This PR squares parameters named "sigma" before inserting them into the appropriate covariance matrices to avoid surprising users due to incorrect naming convention.