search

pymc-devs / pymc-experimental

https://pymc-experimental.readthedocs.io
Other
72 stars 46 forks source link

`test_histogram_approximation` failing due to warning in newer JAX release #305

Closed ricardoV94 closed 4 months ago

ricardoV94 commented 5 months ago

https://github.com/pymc-devs/pymc-experimental/actions/runs/7842985013/job/21402357791?pr=304#step:7:2388

jessegrabowski commented 4 months ago

Appears to be due to https://github.com/google/jax/pull/18989

ricardoV94 commented 4 months ago

Is the histogram functionality using JAX @ferrine? I can't find any evidence for that, but the JAX warning comes from the histogram tests

jessegrabowski commented 4 months ago

I think it's related to pm.sample, not histogram. There are test in test_linear_model and test_model_builder that are also failing because they call pm.sample.

We maybe have to split up the CI so that JAX dependencies are run separately and in JAX mode, like PyMC does

ricardoV94 commented 4 months ago

So if JAX is loaded it will issue a warning on os.fork even if it's not being used?

ricardoV94 commented 4 months ago

Then let's just ignore the warning, it's stupid