search

pymc-devs / pymc-resources

PyMC educational resources
MIT License
1.96k stars 745 forks source link

add notebook for Chapter 4 #188

Closed TomKealy closed 2 years ago

TomKealy commented 2 years ago

This PR adds a notebook for Chapter 4 of Bayes Rules!

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

canyon289 commented 2 years ago

Thanks @TomKealy, theres two notebooks here, which one is the correct one to review?

canyon289 commented 2 years ago

Ive merged the two formats that were proposed into one one main. Please be sure to follow that. From yours I really liked the local file reads.

One thing to note be sure you're using pymc (not pymc3) and that your environment doesnt have theano in it. We're about to move to pymc soon and it would great to ensure these note books don't become oudated immediately

TomKealy commented 2 years ago

@canyon289 Sorry for the confusion -- I did Ch4 and Ch5 in one PR.

I thought I was using pymc by default (and thus aesara, not theano). Do I need to update my env/notebook in any way?

canyon289 commented 2 years ago

No problem, multiple chapters in one PR is fine, they were just both labeled chapter 4 so I was confused.

The safest thing to do is use the build a new environment using the file thats now included in the Bayes Rule directory. It should be working, and this would be a good test if it is.

I can do a more indepth review sometime this week as well for you. Thanks for your continued efforts

TomKealy commented 2 years ago

@canyon289 will rebuild and make any neccesary changes.

The plan is to add 1-2 chapters a week until the book is complete!

canyon289 commented 2 years ago

Sounds good! Ill be sure to review these one extra thoroughly then to give you as much feedback as possible.

Super appreciate your efforts

canyon289 commented 2 years ago

@TomKealy Apologies on the delay, I'll get to reviewing them this weekend

canyon289 commented 2 years ago

@TomKealy any update on these notebooks?

TomKealy commented 2 years ago

Hi @canyon289! I am working on these comments today. Sorry, have been off work ill.

canyon289 commented 2 years ago

Hey, No problem! Just want to make sure youre supported

canyon289 commented 2 years ago

@TomKealy it seems Ci is broken, My apologies on that Ill fix it this weekend for you. Thank you for continuing to support this!