search

pymc-devs / pymc-resources

PyMC educational resources
MIT License
1.96k stars 745 forks source link

Fixed bug that causes GP to only use one column of distance matrix #226

Open daniel-saunders-phil opened 1 year ago

daniel-saunders-phil commented 1 year ago

issue #164 Noted that the Gaussian process code was only using one column of the distance matrix. I updated the input dimensions argument to use all 10 columns. Reran associated plotting cells.

New notebook finds substantially stronger estimates for spatial covariance than old notebook. The new covariances are also even stronger than those reported in the textbook. Its a bit unclear what would reproduce McElreath's textbook example exactly - the textbook might have a typo or code error. And in the 2023 videos for statistical rethinking, it looks like he might also have stronger covariances. So without a clear target for what we are trying to reproduce, I think we should fix the bug and leave the new stronger covariances as is. But do let me know if there is a better plan here.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB